git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: On-branch topic description support?

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 21, 2022, 15:05 UTC
Message-ID
<xmqq35eumrp8.fsf@gitster.g>
In-Reply-To
<xmqqilnr1hff.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 5 quoted lines
>  * "git merge" would learn an option to recognize that the branch
>    being merged has such an empty commit at the tip, and instead
>    merge the parent of the tip of the branch into the integration
>    branch, while using the log message of the discarded tip commit
>    in the log message of the merge itself.

An issue that needs to be worked out at the Porcelain level is that this layout will make "git branch --[no-]merged master", which is an effective way to list what's in and what's left out of the 'master' integration branch, more or less useless. A topic branch with the cover letter commit at the tip may want to be merged to 'next' and then after cooking for a while merged down to 'master', and each time it gets merged, the merge has to leave the cover letter commit alone. In spirit, such a merge commit merges the topic "fully", but at the topological level, the topic is not (and will never be) merged fully, and "git branch --merged next" will not show.

I guess once the topic hits the oldest integration track that it meant to go, we could "pop" the cover letter commit out of the topic, and at that point it would appear to have been merged to 'master' as well as to 'next'. But it would be nice if we did not have to discard the cover letter commit only to please "git branch". IOW, it would be helpful to teach "git branch --[no-]merged" to compute the "right thing" in such a layout.

Previous: Junio C HamanoNext: rsbecker@nexbridge.com
Message 8 of 25 in “On-branch topic description support?”
  1. Junio C HamanoJul 20, 2022
  2. Shaoxuan YuanJul 21, 2022
  3. Elijah NewrenJul 21, 2022
  4. Junio C HamanoJul 21, 2022
  5. Konstantin RyabitsevJul 21, 2022
  6. Philip OakleyJul 21, 2022
  7. Junio C HamanoJul 21, 2022
  8. Junio C HamanoJul 21, 2022
  9. rsbecker@nexbridge.comJul 21, 2022
  10. Konstantin RyabitsevJul 21, 2022
  11. rsbecker@nexbridge.comJul 21, 2022
  12. Ævar Arnfjörð BjarmasonJul 21, 2022
  13. Konstantin RyabitsevJul 21, 2022
  14. Junio C HamanoJul 21, 2022
  15. Ævar Arnfjörð BjarmasonJul 21, 2022
  16. Junio C HamanoJul 21, 2022
  17. Ævar Arnfjörð BjarmasonJul 21, 2022
  18. Junio C HamanoJul 21, 2022
  19. Konstantin RyabitsevJul 21, 2022
  20. Ævar Arnfjörð BjarmasonJul 21, 2022
  21. Konstantin RyabitsevJul 21, 2022
  22. Junio C HamanoJul 21, 2022
  23. Konstantin RyabitsevJul 21, 2022
  24. Junio C HamanoJul 21, 2022
  25. Bagas SanjayaJul 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.