git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] MyFirstContribution: refrain from self-iterating too much

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 22, 2023, 01:51 UTC
Message-ID
<xmqq3583uyk0.fsf@gitster.g>

Finding mistakes in and improving your own patches is a good idea, but doing so too quickly is being inconsiderate to reviewers who have just seen the initial iteration and taking their time to review it. Encourage new developers to perform such a self review before they send out their patches, not after.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/MyFirstContribution.txt | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
diff --git c/Documentation/MyFirstContribution.txt w/Documentation/MyFirstContribution.txt
index 7c9a037cc2..81dcaedf0c 100644
--- c/Documentation/MyFirstContribution.txt
+++ w/Documentation/MyFirstContribution.txt
@@ -1136,6 +1136,26 @@ index 88f126184c..38da593a60 100644
 [[now-what]]
 == My Patch Got Emailed - Now What?
 
+You should wait for your patch to be reviewed by other people in the
+development community.  While you are waiting, you may want to
+re-read what you wrote in the patch you already have sent, as if you
+are a reviewer who is helping you to improve your patch.  But resist
+the temptation to update the patch and send a new one, until other
+people had enough time to digest your original patch and give you
+their reviews.  They may be taking time to give you a carefully
+written review responses and haven't finished it yet.  Bombarding
+them with new versions before they have a chance to react to the
+first iteration is being rude to them.
+
+Of course, you still may spot mistakes and rooms for improvements
+after you sent your initial patch.  Learn from that experience to
+make sure that you will do such a self-review _before_ sending your
+patches next time.  You do not have to send your patches immediately
+once you finished writing them.  It is not a race.  Take your time
+to self-review them, sleep on them, improve them before sending them
+out, and do not allow you to send them before you are reasonably
+sure that you won't find more mistakes in them yourself.
+
 [[reviewing]]
 === Responding to Reviews
 
Next: Torsten Bögershausen
Message 1 of 20 in “MyFirstContribution: refrain from self-iterating too much”
  1. MyFirstContribution: refrain from self-iterating too muchJunio C Hamano, Jan 22, 2023
  2. Torsten BögershausenJan 22, 2023
  3. Junio C HamanoJan 22, 2023
  4. Junio C HamanoJan 22, 2023
  5. MyFirstContribution: refrain from self-iterating too muchJunio C Hamano, Jan 23, 2023
  6. Torsten BögershausenJan 23, 2023
  7. MyFirstContribution: refrain from self-iterating too muchJunio C Hamano, Jul 19, 2023
  8. Linus ArverJul 27, 2023
  9. Junio C HamanoJul 28, 2023
  10. MyFirstContribution: refrain from self-iterating too muchJunio C Hamano, Jul 28, 2023
  11. Jacob AbelJul 28, 2023
  12. Junio C HamanoJul 28, 2023
  13. Re* [PATCH v4] MyFirstContribution: refrain from self-iterating too muchJunio C Hamano, Jul 28, 2023
  14. Jacob AbelJul 29, 2023
  15. Junio C HamanoJul 31, 2023
  16. Linus ArverJul 28, 2023
  17. Junio C HamanoJul 28, 2023
  18. Torsten BögershausenJul 28, 2023
  19. Junio C HamanoJul 28, 2023
  20. Sean AllredJan 23, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.