Re: [PATCH 1/3] test-ctype: test isascii

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2023, 19:02 UTC
Message-ID: <xmqq3579crsd.fsf@gitster.g>
In-Reply-To: <93793a00-da6a-81b4-348f-cd7b946bb9eb@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 6 quoted lines

>> Yes, that does make sense but it is orthogonal to what sane_ctype
>> wants to address, I would think.
>
> Currently we can only use one or the other variant because our sane
> versions use the same names as the locale-aware ones.  Full overlap
> instead of orthogonality.

Ah, that is true but slightly complicated. As long as the caller of walks the string byte-by-byte and calls ispunct() in each iteration, I do not think any "locale aware ispunct()" do much good to us.

Once callers are made locale aware, I am not sure they would still want to call the isfoo() functions that have been know to be very much byte-oriented.

Thanks.