Re: [PATCH] [RFC] transport: add --show-service option

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2023, 04:02 UTC
Message-ID: <xmqq354o8v8u.fsf@gitster.g>
In-Reply-To: <pull.1523.git.1682342241825.gitgitgadget@gmail.com>

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 16 quoted lines

> From: ZheNing Hu <adlternative@gmail.com>
>
> Without using protocol v2, the git server needs to send a pktline
> "# service=$servicename" to the git client first. This often
> requires the git server to implement it independently, but it can
> be delegated to the `git receive-pack` and `git upload-pack` to complete
> the work proactively. Therefore, the `--show-service` option is added
> to `git receive-pack` and `git upload-pack`, which can be used to send
> the "# service=$servicename" pktline, making the logic of the git
> server more concise.
>
> Note that this `--show-service` option can only be used together with
> `--http-backend-info-refs` and it is not applicable when using protocol v2.
>
> Signed-off-by: ZheNing Hu <adlternative@gmail.com>
> ---

The above is a very well written description of why we _can_ do this, but it is unclear why we would _want_ to do this. What do we gain by letting the individual services to declare "we are serving this!"? Do we lose an extra fork & process (it does not seem to be the case)?