Re: [PATCH] setup: trace bare repository setups

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 28, 2023, 20:26 UTC
Message-ID: <xmqq354jda8g.fsf@gitster.g>
In-Reply-To: <ZEv8AcxQW7B2H8uJ@google.com>

Josh Steadmon <steadmon@google.com> writes:

Show 18 quoted lines

> On 2023.04.27 15:54, Junio C Hamano wrote:
>> Josh Steadmon <steadmon@google.com> writes:
>> 
>> > @@ -22,12 +33,12 @@ test_expect_success 'setup bare repo in worktree' '
>> >  '
>> >  
>> >  test_expect_success 'safe.bareRepository unset' '
>> > -	expect_accepted -C outer-repo/bare-repo
>> > +	expect_accepted_implicit -C outer-repo/bare-repo
>> >  '
>> 
>> Perhaps futureproof this test piece by explicitly unsetting the
>> variable before starting the test?  That way, this piece will not be
>> broken even if earlier tests gets modified to set some value to
>> safe.bareRepository in the future.
>
> Actually, explicitly setting the variable here is equivalent to the
> following test case, so I'll just remove this one.

I meant explicitly UNsetting, though?