git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http: handle both "h2" and "h2h3" in curl info lines

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 17, 2023, 09:13 UTC
Message-ID
<xmqq352qsb8g.fsf@gitster.g>
In-Reply-To
<20230617080705.GA2151825@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 22 quoted lines
> On Sat, Jun 17, 2023 at 01:15:59AM -0400, Jeff King wrote:
>
>> Ah, I see. It looks like it depends on which version of curl is using.
>> Perhaps the macOS image in CI has been updated (or maybe the new version
>> just became available via brew or something). I was able to replicate on
>> my Linux system by building and linking against curl 8.1.0, and the
>> patch above (modulo some missing parentheses) fixes it.
>
> Oh, and just to solve this one remaining riddle: it was indeed a change
> in the images. If you click through to the log of the failing osx-clang
> job in your first link, then expand "Set up job" and then "Runner
> image", you'll see that it was using:
>
>   https://github.com/actions/runner-images/blob/macOS-12/20230612.1/images/macos/macos-12-Readme.md
>
> which mentions curl 8.1.2. Whereas on your other link (where the jobs
> did not fail), it was last month's:
>
>   https://github.com/actions/runner-images/blob/macOS-12/20230516.1/images/macos/macos-12-Readme.md
>
> which has curl 8.0.1. So presumably every CI run from here forward will
> fail unless we patch it.
Wow, you are (as usual) thorough.  Thanks for digging.
Previous: Jeff KingNext: Glen Choo
Message 8 of 9 in “Is MacOS CI flaky?”
  1. Glen ChooJun 16, 2023
  2. Junio C HamanoJun 16, 2023
  3. Jeff KingJun 17, 2023
  4. http: handle both "h2" and "h2h3" in curl info linesJeff King, Jun 17, 2023
  5. Jeff KingJun 17, 2023
  6. Jeff KingJun 17, 2023
  7. Jeff KingJun 17, 2023
  8. Junio C HamanoJun 17, 2023
  9. Glen ChooJun 20, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.