Re: [PATCH v0 1/1] Teach git version --build-options about OpenSSL

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 20, 2024, 18:35 UTC
Message-ID: <xmqq34p7v4x1.fsf@gitster.g>
In-Reply-To: <xmqq8qyzv5a3.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> "Randall S. Becker" <the.n.e.key@gmail.com> writes:
>
>> This change uses the OpenSSL supplied OPENSSL_VERSION_TEXT #define supplied
>> for this purpose by that project. If the #define is not present, the version
>> is not reported.
> ...
> If some unknown version of OpenSSL does define it but not as a
> string constant, it would break the build, e.g.,
>
> 	#define OPENSSL_VERSION_TEXT 2 plus 4 is 6
>
> We could stringify it ourselves, but that is probably not worth
> worrying about.
>
> Will queue.  Thanks.

Having said that, we do link with and depend on libraries like libcURL, libPCRE, libz, etc. I wonder if they are also worth reporting, and if so how?

We can leave it just like any other new features, "if you have an itch to see it, you can offer a patch", but I am wondering if we are going to get a several more, we'd at least want to standardize the process and the output (e.g., do we limit the line counts to 1 and line length to some reasonably low number?).

Thanks.