Re: [PATCH] ci(linux32): make Javascript Actions work in x86 mode

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2024, 17:17 UTC
Message-ID: <xmqq34m2tasj.fsf@gitster.g>
In-Reply-To: <20240914072932.GB1284567@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> I'm not totally opposed to this direction, but I'm a little concerned
> about the stability/maintenance of the solution. In particular:
>
>> +        NODE_URL=https://unofficial-builds.nodejs.org/download/release/v20.17.0/node-v20.17.0-linux-x86.tar.gz &&
> ...
>> +        curl -Lo /tmp/node.tar.gz $NODE_URL &&
>> +        tar -C /__e/node20 -x --strip-components=1 -f /tmp/node.tar.gz
>
> This is pretty intimate with how Actions work (both the node20 version
> and the "/__e/" magic). It's hard to say if/when that would bite us.

Thanks for clearly expressing the uneasiness I felt, which I could not turn into concrete words, when I saw the patch first time.

Each of these approaches may have its pros and cons, but I somehow do not see that the newly proposed alternative is 10x better than what was reviewed and queued already to be worth the effort to replace it.

Thanks, both.