Re: [PATCH 2/2] doc: correct misleading descriptions for --shallow-exclude
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 5, 2024, 06:55 UTC
- Message-ID
- <xmqq34k6tbjv.fsf@gitster.g>
- In-Reply-To
- <Zym6723csrUdiC5A@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 15 quoted lines
> On Mon, Nov 04, 2024 at 07:02:44PM +0000, Elijah Newren via GitGitGadget wrote:
>> diff --git a/builtin/clone.c b/builtin/clone.c
>> index 59fcb317a68..93fe6d69659 100644
>> --- a/builtin/clone.c
>> +++ b/builtin/clone.c
>> @@ -147,7 +147,7 @@ static struct option builtin_clone_options[] = {
>> N_("create a shallow clone of that depth")),
>> OPT_STRING(0, "shallow-since", &option_since, N_("time"),
>> N_("create a shallow clone since a specific time")),
>> - OPT_STRING_LIST(0, "shallow-exclude", &option_not, N_("revision"),
>> + OPT_STRING_LIST(0, "shallow-exclude", &option_not, N_("ref"),
>> N_("deepen history of shallow clone, excluding rev")),
>
> We also need to replace "rev" with "ref" here. We already do that in the
> other cases.Ah, I missed that one. Let me locally amend, as there does not seem to be any other issues.