git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] doc: correct misleading descriptions for --shallow-exclude

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 5, 2024, 06:55 UTC
Message-ID
<xmqq34k6tbjv.fsf@gitster.g>
In-Reply-To
<Zym6723csrUdiC5A@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 15 quoted lines
> On Mon, Nov 04, 2024 at 07:02:44PM +0000, Elijah Newren via GitGitGadget wrote:
>> diff --git a/builtin/clone.c b/builtin/clone.c
>> index 59fcb317a68..93fe6d69659 100644
>> --- a/builtin/clone.c
>> +++ b/builtin/clone.c
>> @@ -147,7 +147,7 @@ static struct option builtin_clone_options[] = {
>>  		    N_("create a shallow clone of that depth")),
>>  	OPT_STRING(0, "shallow-since", &option_since, N_("time"),
>>  		    N_("create a shallow clone since a specific time")),
>> -	OPT_STRING_LIST(0, "shallow-exclude", &option_not, N_("revision"),
>> +	OPT_STRING_LIST(0, "shallow-exclude", &option_not, N_("ref"),
>>  			N_("deepen history of shallow clone, excluding rev")),
>
> We also need to replace "rev" with "ref" here. We already do that in the
> other cases.

Ah, I missed that one. Let me locally amend, as there does not seem to be any other issues.

Previous: Patrick SteinhardtNext: Junio C Hamano
Message 6 of 7 in “A few --shallow-exclude fixes”
  1. 0/2 A few --shallow-exclude fixesElijah Newren via GitGitGadget, Nov 4, 2024
  2. 1/2 upload-pack: fix ambiguous error messageElijah Newren via GitGitGadget, Nov 4, 2024
  3. Patrick SteinhardtNov 5, 2024
  4. 2/2 doc: correct misleading descriptions for --shallow-excludeElijah Newren via GitGitGadget, Nov 4, 2024
  5. Patrick SteinhardtNov 5, 2024
  6. Junio C HamanoNov 5, 2024
  7. Junio C HamanoNov 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.