Re: [PATCH] sparse: ignore warning from new glibc headers

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2025, 22:35 UTC
Message-ID: <xmqq34eiuvry.fsf@gitster.g>
In-Reply-To: <77f82414-261c-d2bc-f911-ed3d4b06c86e@gmx.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Due to the brownouts today (see
> https://github.com/actions/runner-images/issues/11101, surfaced e.g. in
> https://github.com/git/git/actions/runs/14342895944/job/40206357016), your
> patch came in handy, as it is required for the following fix:

Good timing ;-) cf. https://lore.kernel.org/git/xmqqo6x6wgs8.fsf@gitster.g/

>
> -- snipsnap --

Does mailinfo consider this as a scissors line?

Show 8 quoted lines

> Subject: [PATCH] ci: upgrade `sparse` to supported build agents
>
> The `sparse` job still uses the `ubuntu-20.04` runner pool, but that
> pool is about to go away, so let's stop using it.
>
> There is no `sparse-22.04` artifact provided by the "Build sparse for
> Ubuntu" Azure Pipeline, but that is not necessary anyway because Ubuntu
> 22.04 has the `sparse` package: https://packages.ubuntu.com/jammy/sparse

Perfect.  Will take a look.

Thanks.

Show 47 quoted lines

> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  .github/workflows/main.yml | 11 +----------
>  ci/install-dependencies.sh |  2 +-
>  2 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index ff44c0a8c067..c9455246269d 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -449,20 +449,11 @@ jobs:
>      if: needs.ci-config.outputs.enabled == 'yes'
>      env:
>        jobname: sparse
> -    runs-on: ubuntu-20.04
> +    runs-on: ubuntu-22.04
>      concurrency:
>        group: sparse-${{ github.ref }}
>        cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}
>      steps:
> -    - name: Download a current `sparse` package
> -      # Ubuntu's `sparse` version is too old for us
> -      uses: git-for-windows/get-azure-pipelines-artifact@v0
> -      with:
> -        repository: git/git
> -        definitionId: 10
> -        artifact: sparse-20.04
> -    - name: Install the current `sparse` package
> -      run: sudo dpkg -i sparse-20.04/sparse_*.deb
>      - uses: actions/checkout@v4
>      - name: Install other dependencies
>        run: ci/install-dependencies.sh
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 0df74610d063..8700c0f2924d 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -119,7 +119,7 @@ StaticAnalysis)
>  sparse)
>  	sudo apt-get -q update -q
>  	sudo apt-get -q -y install libssl-dev libcurl4-openssl-dev \
> -		libexpat-dev gettext zlib1g-dev
> +		libexpat-dev gettext zlib1g-dev sparse
>  	;;
>  Documentation)
>  	sudo apt-get -q update
> --
> 2.49.0.windows.1