git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jul 2025, #08; Mon, 28)

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 29, 2025, 15:30 UTC
Message-ID
<xmqq34afqaj8.fsf@gitster.g>
In-Reply-To
<87ms8na1mc.fsf@iotcl.com>
Toon Claes <toon@iotcl.com> writes:
Show 34 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> * ps/object-file-wo-the-repository (2025-07-16) 17 commits
>>  - object-file: get rid of `the_repository` in index-related functions
>>  - object-file: get rid of `the_repository` in `force_object_loose()`
>>  - object-file: get rid of `the_repository` in `read_loose_object()`
>>  - object-file: get rid of `the_repository` in loose object iterators
>>  - object-file: remove declaration for `for_each_file_in_obj_subdir()`
>>  - object-file: inline `for_each_loose_file_in_objdir_buf()`
>>  - object-file: get rid of `the_repository` when writing objects
>>  - odb: introduce `odb_write_object()`
>>  - loose: write loose objects map via their source
>>  - object-file: get rid of `the_repository` in `finalize_object_file()`
>>  - object-file: get rid of `the_repository` in `loose_object_info()`
>>  - object-file: get rid of `the_repository` when freshening objects
>>  - object-file: inline `check_and_freshen()` functions
>>  - object-file: get rid of `the_repository` in `has_loose_object()`
>>  - object-file: stop using `the_hash_algo`
>>  - object-file: fix -Wsign-compare warnings
>>  - Merge branch 'ps/object-store' into ps/object-file-wo-the-repository
>>
>>  Reduce implicit assumption and dependence on the_repository in the
>>  object-file subsystem.
>>
>>  Comments?
>>  source: <20250717-pks-object-file-wo-the-repository-v2-0-36d2cd6c700e@pks.im>
>
> I did do a thorough review on v1 in the past and did a little less
> thorough review on v2, but the range-diff is tiny anyway.
>
> Version two removes the controversial commits around global config. With
> this, this patch series is not able to drop USE_THE_REPOSITORY_VARIABLE
> from the object-file.c yet. Nevertheless, the whole series is still
> worthwhile to me.

Thanks, I do recall reading your earlier reviews and they looked sensible.

Previous: Toon Claes
Message 5 of 5 in “What's cooking in git.git (Jul 2025, #08; Mon, 28)”
  1. Junio C HamanoJul 29, 2025
  2. Junio C HamanoJul 29, 2025
  3. Patrick SteinhardtJul 29, 2025
  4. Toon ClaesJul 29, 2025
  5. Junio C HamanoJul 29, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.