Re: What's cooking in git.git (Mar 2026, #12)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 31, 2026, 15:27 UTC
- Message-ID
- <xmqq341g3tol.fsf@gitster.g>
- In-Reply-To
- <actaFN8ds0cfgWxI@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 16 quoted lines
> On Mon, Mar 30, 2026 at 05:10:42PM -0700, Junio C Hamano wrote: >> * ps/commit-graph-overflow-fix (2026-03-23) 1 commit >> - commit-graph: fix writing generations with dates exceeding 34 bits >> >> Fix a regression in writing the commit-graph where commits with dates >> exceeding 34 bits (beyond year 2514) could cause an underflow and >> crash Git during the generation data overflow chunk writing. >> >> Waiting for review response. >> cf. <xmqq1ph92pzs.fsf@gitster.g> >> source: <20260324-pks-commit-graph-overflow-v2-1-843568cf8780@pks.im> > > Shall this also be marked as "Will merge to next" based on our last > discussion at [1]? I mostly want to ensure this is part of rc0 so that > the regression isn't part of any tagged release, even if it's just a > release candidate.
Even though I still feel uncomfortable hurrying to merge down an obviously UB code, instead of an uglier but far safer conditional compilation, patching it on top is trivial, so let's mark it for 'next'. Thanks for spotting.