git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] format-patch: introduce format.defaultTo

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 6, 2014, 20:38 UTC
Message-ID
<xmqq1u0kj16h.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140106201854.GA28162@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 35 quoted lines
> On Mon, Jan 06, 2014 at 12:06:51PM -0800, Junio C Hamano wrote:
>
>> Unless you set @{u} to this new configuration, in which case the
>> choice becomes dynamic depending on the current branch, but
>> 
>>  - if that is the only sane choice based on the current branch, why
>>    not use that as the default without having to set the
>>    configuration?
>> 
>>  - Or if that is still insufficient, don't we need branch.*.forkedFrom
>>    that is different from branch.*.merge, so that different branches
>>    you want to show "format-patch" output can have different
>>    reference points?
>
> Yeah, I had similar thoughts. I personally use "branch.*.merge" as
> "forkedFrom", and it seems like we are going that way anyway with things
> like "git rebase" and "git merge" defaulting to upstream. But then there
> is "git push -u" and "push.default = upstream", which treats the
> upstream config as something else entirely.
>
> So it seems like there is already some confusion, and either way we go,
> thisis making it worse to some degree (I do not blame Ram, but rather he
> has stumbled into a hidden sand pit that we have been building for the
> past few years... :).
>
> I wonder if it is too late to try to clarify this dual usage. It kind of
> seems like the push config is "this is the place I publish to". Which,
> in many workflows, just so happens to be the exact same as the place you
> forked from. Could we introduce a new branch.*.pushupstream variable
> that falls back to branch.*.merge? Or is that just throwing more fuel on
> the fire (more sand in the pit in my analogy, I guess).
>
> I admit I haven't thought it through yet, though. And even if it does
> work, it may throw a slight monkey wrench in the proposed push.default
> transition.

Yeah, when I say "upstream", I never mean it as "where I publish". Your upstream is where you get others' work from.

For a "push to somewhere for safekeeping or other people to look at" triangular workflow, it does not make any sense to treat that "I publish there" place as an upstream (hence having branch.*.remote pointing at that publishing point). Once you stop doing that, and instead using branch.*.remote = origin, and branch.*.merge = master, where 'origin' is not your publishing point, @{u} will again start making sense, I think.

And I thought that is what setting "remote.pushdefault" to the publishing point repository was about.

Previous: Jeff KingNext: Jeff King
Message 19 of 37 in “Minor convinience feature: format.defaultTo”
  1. 0/2 Minor convinience feature: format.defaultToRamkumar Ramachandra, Jan 6, 2014
  2. 1/2 completion: complete format.coverLetterRamkumar Ramachandra, Jan 6, 2014
  3. Ramkumar RamachandraJan 7, 2014
  4. 2/2 format-patch: introduce format.defaultToRamkumar Ramachandra, Jan 6, 2014
  5. Jonathan NiederJan 6, 2014
  6. Ramkumar RamachandraJan 6, 2014
  7. Junio C HamanoJan 6, 2014
  8. Ramkumar RamachandraJan 6, 2014
  9. Junio C HamanoJan 6, 2014
  10. Jeff KingJan 6, 2014
  11. John SzakmeisterJan 6, 2014
  12. Jonathan NiederJan 6, 2014
  13. John SzakmeisterJan 6, 2014
  14. Junio C HamanoJan 6, 2014
  15. Ramkumar RamachandraJan 6, 2014
  16. John SzakmeisterJan 7, 2014
  17. Ramkumar RamachandraJan 7, 2014
  18. Jeff KingJan 6, 2014
  19. Junio C HamanoJan 6, 2014
  20. Jeff KingJan 6, 2014
  21. Junio C HamanoJan 6, 2014
  22. Ramkumar RamachandraJan 6, 2014
  23. Jeff KingJan 7, 2014
  24. Junio C HamanoJan 7, 2014
  25. Jeff KingJan 7, 2014
  26. Junio C HamanoJan 7, 2014
  27. Jeff KingJan 7, 2014
  28. Junio C HamanoJan 7, 2014
  29. Felipe ContrerasApr 10, 2014
  30. Ramkumar RamachandraJan 6, 2014
  31. Junio C HamanoJan 6, 2014
  32. Ramkumar RamachandraJan 6, 2014
  33. Jeff KingJan 7, 2014
  34. Ramkumar RamachandraJan 7, 2014
  35. Jeff KingJan 7, 2014
  36. Felipe ContrerasApr 10, 2014
  37. Ramkumar RamachandraJan 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.