Re: [RFD] use approxidate for "git commit --date=xyz"?

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 30, 2014, 21:34 UTC
Message-ID: <xmqq1tweec1o.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CA+55aFx=LizEyS6hq=av_qwRZuu_q3xPSXO-Jr4CAfXqaAuUtA@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 7 quoted lines

> I just got a comment saying that
>
>     git commit --amend --date=now
>
> doesn't work. I replied that you can use
>
>    --date="$(date)"

Offhand without double-checking the actual codepath I do not have objection against approxidate-careful.

But why does the workflow need --date=now in the first place? Wouldn't --reset-author do what you want better? What is the situation where you want to say that this patch has been changed significantly enough from the original to label it with the current timestamp without taking the authorship?

Show 8 quoted lines

> but I do wonder if we should accept the approxidate format - we do in
> other equivalent places. Hmm?
>
> The code uses fmt_ident(), which uses parse_date(), which in turn uses
> parse_date_basic(). Maybe parse_date() could use
> "approxidate_careful()" instead of "parse_date_basic()"?
>
>             Linus