git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-am: add option to extract email Message-Id: tag into commit log

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 2, 2014, 17:17 UTC
Message-ID
<xmqq1tu3isti.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1404291113-4424-1-git-send-email-avi@cloudius-systems.com>
Avi Kivity <avi@cloudius-systems.com> writes:
Show 7 quoted lines
> +		if test 't' == "$message_id"
> +		then
> +			grep ^Message-Id: "$dotest/info" || true
> +		fi
>  		if test '' != "$ADD_SIGNOFF"
>  		then
>  			echo "$ADD_SIGNOFF"

Seeing how existing code carefully makes sure that ADD_SIGNOFF has an empty line before it when and only when necessary to ensure that there is a blank after the existing log message, I would suspect that this patch that blindly inserts a line is doubly wrong. The output from "grep" may be appended without adding a blank when necessary, and appending of ADD_SIGNOFF may end up adding an extra blank after Message-Id. Am I reading the patch wrong?

Previous: Avi KivityNext: Avi Kivity
Message 6 of 7 in “git-am: add option to extract email Message-Id: tag into commit log”
  1. git-am: add option to extract email Message-Id: tag into commit logAvi Kivity, Jul 2, 2014
  2. Torsten BögershausenJul 2, 2014
  3. Avi KivityJul 2, 2014
  4. Fabian RuchJul 2, 2014
  5. Avi KivityJul 2, 2014
  6. Junio C HamanoJul 2, 2014
  7. Avi KivityJul 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.