Re: profile-fast is failing in my Git 2.2.1 build from tar in a Git repo

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2015, 23:13 UTC
Message-ID: <xmqq1tn7o63p.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1420408723.7095.207.camel@homebase>

Paul Smith <paul@mad-scientist.net> writes:

> Is anyone aware of this?  It seems that profile-fast fails when invoked
> from a downloaded tarball, if you are in a Git repository when you
> unpack it.

Not me (I don't do profile build), but I am not surprised.

Show 14 quoted lines

> The problem is in the t/perf/perf-lib.sh:test_perf_create_repo_from()
> function, where we see this:
>
>   repo="$1"
>   source="$2"
>   source_git=$source/$(cd "$source" && git rev-parse --git-dir)
>
> The function is invoked as:
>
>   test_perf_create_repo_from '/home/psmith/src/git-2.2.1/t/perf/trash
> directory.p5302-pack-index' /home/psmith/src/git-2.2.1/t/..
>
> but this doesn't work, because "$source" is not a Git repository; it's
> the root of the unpacked tarball.

Yup, that is exactly why I said I am not surprised.

I do not think profile build is prepared to be run without having our history (after all, it is not test_perf_create_REPO_from, not test_perf_create_source_directory_of_git_from). It wants to create a repository that hosts a reasonably sized but not too big a project, i.e. us.

The safest and cleanest fix would be to make sure that the said function checks if $source/.git is a repository, perhaps?