Re: [PATCH 2/2] support for --no-relative and diff.relative

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 12, 2015, 23:17 UTC
Message-ID: <xmqq1tlupvmj.fsf@gitster.dls.corp.google.com>
In-Reply-To: <54A2FDD2.3010707@shysecurity.com>

These two patches

    * bp/diff-relative-config (2015-01-07) 2 commits
     - diff: teach diff.relative to give default to --relative=<value>
     - diff: teach --no-relative to override earlier --relative

have been sitting in my Undecided pile, primarily because I am wary of touching a core command like "diff" with just me reviewing. I think they look reasonably safe (especially since the configuration parsing is done only in diff_ui_config()), but I may have overlooked something obvious and silly.

Another set or two of eyeballs are very much appreciated.

Thanks.