git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] mergetools: add winmerge as a builtin tool

From
Junio C Hamano <gitster@pobox.com>
Date
May 20, 2015, 20:03 UTC
Message-ID
<xmqq1tibnhif.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150520085346.GA99001@gmail.com>
David Aguilar <davvid@gmail.com> writes:
Show 22 quoted lines
> On Wed, May 20, 2015 at 09:47:56AM +0200, Sebastian Schuberth wrote:
>> On Wed, May 20, 2015 at 9:42 AM, David Aguilar <davvid@gmail.com> wrote:
>> 
>> > +       OIFS=$IFS
>> > +       IFS='
>> > +'
>> 
>> I guess this is just a formatting issue with the mail export as it should read
>> 
>> IFS=$'\n'
>> 
>> Otherwise looks good to me.
>> 
>> -- 
>> Sebastian Schuberth
>
> Thanks for the review.
>
> That's actually a literal newline inside a single-quoted string.
>
> I'm not sure how portable $'\n' is, but the '<literal-newline>'
> approach is used often in the git code.

Thanks for being observant ;-) Unless it is contrib/completion that is known to be run with bash, please avoid $'string' and $"string".

Previous: David Aguilar
Message 4 of 4 in “mergetools: add winmerge as a builtin tool”
  1. mergetools: add winmerge as a builtin toolDavid Aguilar, May 20, 2015
  2. Sebastian SchuberthMay 20, 2015
  3. David AguilarMay 20, 2015
  4. Junio C HamanoMay 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.