Re: [PATCH] --count feature for git shortlog

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 29, 2015, 04:37 UTC
Message-ID: <xmqq1tgvdt9u.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1435540922-12208-1-git-send-email-lawrencesiebert@gmail.com>

Lawrence Siebert <lawrencesiebert@gmail.com> writes:

Show 6 quoted lines

> This is a new feature for short log, which lets you count commits on a per
> file or repository basis easily.
>
> Currently if you want a total count of commits with shortlog, you would
> need to add up each authors commits after using --summary. This adds a 
> -N / --count option to shortlog for this purpose.

  
The standard way to do that is

    git log --oneline ... whatever other args ... | wc -l

or more kosher from a script

    git rev-list ... whatever other args ... | wc -l

Adding an option to ignore per-author breakdown smells backwards. The whole point of shortlog is to give you the commit stats broken out for each author. I guess it is not so far-fetched to add an option to "git log" to only show the number of commits that would be output, if you really wanted to avoid "| wc -l", but this option does not belong to shortlog.

And it certainly does not deserve a short-and-sweet single letter option "-N", I think.