git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: return non-zero error code if format-patch fails

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 6, 2015, 17:01 UTC
Message-ID
<xmqq1tgl2pav.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150706085326.GA30731@musxeris015.imu.intel.com>
Clemens Buchacher <clemens.buchacher@intel.com> writes:
Show 15 quoted lines
> On Fri, Jul 03, 2015 at 10:52:32AM -0700, Junio C Hamano wrote:
>> >
>> > Cc: Andrew Wong <andrew.kw.w@gmail.com>
>> > Signed-off-by: Clemens Buchacher <clemens.buchacher@intel.com>
>> > Reviewed-by: Jorge Nunes <jorge.nunes@intel.com>
>> 
>> Where was this review made?  I may have missed a recent discussion,
>> and that is why I am asking, because Reviewed-by: lines that cannot
>> be validated by going back to the list archive does not add much
>> value.
>
> Jorge helped me by reviewing the patch before I submitted it to the
> list. My intention is to give credit for his contribution, and to
> involve him in any discussion regarding the patch. Maybe it makes more
> sense to say Helped-by:?

Thanks; I think that clarifies it, and I think that is how people seem to use Helped-by around here.

Previous: Clemens Buchacher
Message 4 of 4 in “rebase: return non-zero error code if format-patch fails”
  1. rebase: return non-zero error code if format-patch failsClemens Buchacher, Jul 2, 2015
  2. Junio C HamanoJul 3, 2015
  3. Clemens BuchacherJul 6, 2015
  4. Junio C HamanoJul 6, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.