Re: [PATCH] submodule: implement `module_name` as a builtin helper

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2015, 22:18 UTC
Message-ID: <xmqq1tfeyc6p.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAGZ79kZx=ML-tT6vvjynZ91x6JYqpgKVaEp-Q43MShz0J2EanQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 16 quoted lines

> On Fri, Aug 7, 2015 at 2:32 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>>>> If we followed what you just said, that patch will try to directly
>>>> read the data in config_name_for_path string list, which is removed
>>>> by Heiko's series, if I am reading it right.
>>
>> By the way, the above is more important part of the message you are
>> responding to.  The result does not simply link, because your
>> unsorted_string_list_lookup() will no longer have the string list in
>> the first place X-<.
>
> I looked through Heikos series and think it is an improvement. I mean I
> can redo my patches on top of his. Specially this patch will be easy,
> as patch 2/4 (extract functions for submodule config set and lookup)
> implements get_name_for_path. All I would need to do then is expose it
> to the shell via the helper.

Yes, that is exactly what I said a few messages ago, wasn't it?

But that would require that you read and understand Heiko's work and that you understand what its future direction should be, communicate that vision to others to share, before building on top of it. And with that effort, you would already be in a good position to polish Heiko's stalled work and move it forward. After all, you cannot just build on a stalled work, declare "my part is done; the result is not mergeable because the foundation is not cooked, but that is not my problem" ;-).

IIRC, the issues around the topic were nothing show-stopping, but the primary reason it stalled was that Heiko got busy with his other obligations, so I'd appreciate others like you to help the topic move forward.

Thanks.