Re: [PATCH v11 11/13] tag.c: use 'ref-filter' APIs

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2015, 19:00 UTC
Message-ID: <xmqq1tf1eo4w.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1439661643-16094-12-git-send-email-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 23 quoted lines

> We improve the sorting option provided by 'tag.c' by using the sorting
> options provided by 'ref-filter'. This causes the test 'invalid sort
> parameter on command line' in t7004 to fail, as 'ref-filter' throws an
> error for all sorting fields which are incorrect. The test is changed
> to reflect the same.
> ...
> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index d31788c..1f066aa 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -1462,13 +1462,7 @@ test_expect_success 'invalid sort parameter on command line' '
>  
>  test_expect_success 'invalid sort parameter in configuratoin' '
>  	git config tag.sort "v:notvalid" &&
> -	git tag -l "foo*" >actual &&
> -	cat >expect <<-\EOF &&
> -	foo1.10
> -	foo1.3
> -	foo1.6
> -	EOF
> -	test_cmp expect actual
> +	test_must_fail git tag -l "foo*" >actual
>  '

You don't have to redirect the output to "actual", then.