Re: [PATCH] doc: add note about ignoring --no-create-reflog
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 1, 2017, 23:54 UTC
- Message-ID
- <xmqq1svhmpqo.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170201233202.p462dggidiiyx6s6@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 24 quoted lines
> On Wed, Feb 01, 2017 at 03:27:09PM -0800, Junio C Hamano wrote: > >> I had the same trouble wording. Another thing I noticed was that I >> deliberately left it vague what "default" this does not override, >> because it appears to me that those who do not set logallrefupdates >> will get the compiled-in default and that is also not overriden. >> >> IOW, "does not negate the setting of core.logallrefupdates" will >> open us to reports "I do not have the configuration set, but I still >> get reflog even when --no-create-reflog is given". >> >> The negated form `--no-create-reflog` currently does not negate >> the default; it overrides an earlier `--create-reflog`, though. >> >> perhaps? > > True. I thought the default was "off", and that we merely set the config > when initializing a repo. But looking again, it really is checking > is_bare_repository() at runtime. > > I still think it is OK to mention, as the description of > core.logallrefupdates is where we document the behavior and the > defaults. So even with "I do not have it set", that is still the key to > find more information.
OK, let's take yours as the final and merge it down to 'next' soonish.