Re: [WIP/PATCH 7/6] perf: add a performance test for core.fsmonitor

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 4, 2017, 01:59 UTC
Message-ID: <xmqq1sr0wm0i.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170602102853.23073-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 9 quoted lines

> This is WIP code for the reasons explained in the setup comments,
> unfortunately the perf code doesn't easily allow you to run different
> setup code for different versions you're testing. This test will stop
> working if the fsmonitor is merged into the master branch.
> ...
> +
> +	# Relies on core.fsmonitor not being merged into master. Needs
> +	# better per-test ways to disable it if it gets merged.
> +	git config core.fsmonitor true &&

Will stop working and relies on not merged can be read but I cannot read "why" explained, and I cannot quite guess what the reason is.

If the code to read the configuration is not there, setting this would not have any effect. If the code is there, setting this would have effect (either talking fsmonitor helps or it hurts).

And I do not think we'd ever see a version of Git that always relies on talking to fsmonitor, i.e. "git config core.fsmonitor false" is not a way to disable it, so...

Puzzled.