git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/: add UNLEAKs

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 2, 2017, 04:07 UTC
Message-ID
<xmqq1smmqjk1.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171001174208.1693753-1-martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
> ... While addressing `msg` in builtin/tag.c, convert the existing
> `strbuf_release()` calls as well.

That part of this patch made me raise eyebrows a bit but only slightly. We are about to leave the function to exit anyway, and all the other that got new UNLEAK(var) at the end are doing the same thing.

So overall I think this patch makes sense.  Thanks.
Previous: Martin ÅgrenNext: Jeff King
Message 2 of 5 in “builtin/: add UNLEAKs”
  1. builtin/: add UNLEAKsMartin Ågren, Oct 1, 2017
  2. Junio C HamanoOct 2, 2017
  3. Jeff KingOct 2, 2017
  4. Martin ÅgrenOct 2, 2017
  5. Junio C HamanoOct 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.