Re: [PATCH v5 01/35] pkt-line: introduce packet_read_with_status

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 14, 2018, 21:33 UTC
Message-ID: <xmqq1sgmz6j0.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180314183213.223440-2-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

Show 11 quoted lines

> +/*
> + * Read a packetized line into a buffer like the 'packet_read()' function but
> + * returns an 'enum packet_read_status' which indicates the status of the read.
> + * The number of bytes read will be assigined to *pktlen if the status of the
> + * read was 'PACKET_READ_NORMAL'.
> + */
> +enum packet_read_status {
> +	PACKET_READ_EOF,
> +	PACKET_READ_NORMAL,
> +	PACKET_READ_FLUSH,
> +};

EOF was -1 and NORMAL was 0 in the previous round; do we need to read through all the invocations of functions that return this type and make sure there is no "while (such_a_function())" that used to see if we read NORMAL that is left un-updated?

I just have gone thru all the hits from

 $ git grep -n -e packet_erad_with_status -e packet_reader_read -e packet_reader_peek

There are a few

	switch (packet_reader_peek())

which by definition we do not have to worry about. Then majority of what could be problematic are of the form:

	while (packet_reader_read() == PACKET_READ_NORMAL)

and they were this way even in the previous version, so it seems quite alright.

Will replace.  Thanks.