git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add initial support for pax extended attributes

From
Junio C Hamano <gitster@pobox.com>
Date
May 23, 2018, 23:38 UTC
Message-ID
<xmqq1se2uelx.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180523045714.GA5567@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 5 quoted lines
> I do think we'd fail to notice the truncation, which isn't ideal. But it
> looks like the rest of the script suffers from the same issue.
>
> If anybody cares, it might not be too hard to wrap all of the 512-byte
> read calls into a helper that dies on bogus input.

Perhaps. In any case, the patch presented here is an improvement over the status quo, so let's move the world forward by taking it without any further "while at it" fixes, which can come later when people feel inclined to do so.

Thanks, both, for writing and reviewing ;-)
Previous: Jeff KingNext: Pedro Alvarez
Message 4 of 6 in “Add initial support for pax extended attributes”
  1. Add initial support for pax extended attributesPedro Alvarez, May 22, 2018
  2. Junio C HamanoMay 23, 2018
  3. Jeff KingMay 23, 2018
  4. Junio C HamanoMay 23, 2018
  5. 0/1 import-tars: read overlong names from pax extended headerPedro Alvarez, May 23, 2018
  6. 1/1 import-tars: read overlong names from pax extended headerPedro Alvarez, May 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.