Re: [PATCH v2] pack-objects: Use packing_data lock instead of read_mutex

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 22, 2019, 22:43 UTC
Message-ID: <xmqq1s54e2ju.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190119154337.6556-1-phogg@novamoon.net>

Patrick Hogg <phogg@novamoon.net> writes:

> As I mentioned in the prior thread I think that it will be simpler
> to simply use the existing lock in packing_data instead of moving
> read_mutex. I can go back to simply moving read_mutex to the
> packing_data struct if that that is preferable, though.

I'll let others comment on this to show preference between the two approaches.

Show 5 quoted lines

> I also removed the #ifndef NO_PTHREADS in prepare_packing_data around
> the initialization of &pdata->lock since I had to upgrade the lock to
> a recursive mutex. As far as I can tell init_recursive_mutex (and
> pthread_mutex_init for that matter) have that protection already so it
> appears to be redundant.

If you can defer "I also" to a separate patch, please do so. Keeping the fix alone as small as possible and not tangled with other changes would make it easier for people to cherry-pick the fix to older maintenance tracks if they choose to.