Re: [PATCH 2/3] Doc: add more detail for git-format-patch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 20, 2019, 19:01 UTC
- Message-ID
- <xmqq1rxfveym.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <7619da962d1fc804392e3552fbd56bf4bc68ac38.1566182184.git.liu.denton@gmail.com>
Denton Liu <liu.denton@gmail.com> writes:
Show 11 quoted lines
> Next, while we're at it, surround option arguments with <>. > ... > [--start-number <n>] [--numbered-files] > - [--in-reply-to=Message-Id] [--suffix=.<sfx>] > + [--in-reply-to=<Message-Id>] [--suffix=.<sfx>] > [--ignore-if-in-upstream] > - [--rfc] [--subject-prefix=Subject-Prefix] > + [--rfc] [--subject-prefix=<Subject-Prefix>] > ... > ---in-reply-to=Message-Id:: > +--in-reply-to=<Message-Id>::
That is a good change, but if we are making this change while are at it, I think we should fix it to read <message id>. "Message-Id" is a good spelling iff we are talking about the label on the left hand side of colon in e-mail header, but in this context, we are talking about the value to be placed on that header.
All the other multi-word placeholders in the SYNOPSIS section spell the words as normal multiple words separated with whitespace in lower case. You'd also want to fix the spelling of Subject-Prefix to <subject prefix> for consistency.
Thanks.