Re: [PATCH 1/1] git-gui: remove unused global declarations

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 25, 2019, 03:54 UTC
Message-ID: <xmqq1rv1eaz1.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191025013255.7367-2-me@yadavpratyush.com>

Pratyush Yadav <me@yadavpratyush.com> writes:

Show 5 quoted lines

>  proc next_diff {{after {}}} {
> -	global next_diff_p next_diff_w next_diff_i
> +	global next_diff_p next_diff_w
>  	show_diff $next_diff_p $next_diff_w {} {} $after
>  }

Not in particular about next_diff_i, but seeing a hunk like this makes me wonder if you want to go the other way around. If a future fix needs to (re)introduce the use of next_diff_i global variable in this proc (it seems that there are two procs that declare the variable as global, one of which is this one, and the other one assigns to it), the code change must resurrect this declaration; otherwise the code would only confuse itself by potentially having two variables (one global, one local) with the same name, no?

For next_diff_i in particular, I think the right solution would be to remove both global decl and the assignment, as the assignment is made to otherwise unused variable. But the primary point in such a change is not "remove unused global decl"; it is "remove unused variable".