Re: [PATCH v5 05/15] git-p4: promote encodeWithUTF8() to a global function

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2019, 16:39 UTC
Message-ID: <xmqq1rtarf3j.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <11d7703e411f1dced8a34defc68922ba44c614d5.1575740863.git.gitgitgadget@gmail.com>

"Ben Keene via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 10 quoted lines

> From: Ben Keene <seraphire@gmail.com>
>
> This changelist is an intermediate submission for migrating the P4
> support from Python 2 to Python 3. The code needs access to the
> encodeWithUTF8() for support of non-UTF8 filenames in the clone class as
> well as the sync class.
>
> Move the function encodeWithUTF8() from the P4Sync class to a
> stand-alone function.  This will allow other classes to use this
> function without instanciating the P4Sync class.

Makes quite a lot of sense, as I do not see a reason why this needs to be attached to any specific instance of P4Sync.