git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep: avoid using oid_to_hex() with parse_object_or_die()

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 28, 2020, 22:44 UTC
Message-ID
<xmqq1rkvclak.fsf@gitster.c.googlers.com>
In-Reply-To
<CAHd-oW68nGch8b3tfas4AUUgA8so-ihwazAf8-W-xQNPi31=Mw@mail.gmail.com>
Matheus Tavares Bernardino <matheus.bernardino@usp.br> writes:
Show 14 quoted lines
> On Tue, Jul 28, 2020 at 6:40 PM René Scharfe <l.s.r@web.de> wrote:
>>
>> parse_object_or_die() is passed an object ID and a name to show if the
>> object cannot be parsed.  If the name is NULL then it shows the
>> hexadecimal object ID.  Use that feature instead of preparing and
>> passing the hexadecimal representation to the function proactively.
>> That's shorter and a bit more efficient.
>>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>
> Good catch. And this seems to be the only place where we use
> `parse_object_or_die(oid, oid_to_hex(oid))`.
>
> Reviewed-by: Matheus Tavares <matheus.bernardino@usp.br>
Yup, makes sense.  Thanks, both.
Previous: Matheus Tavares Bernardino
Message 3 of 3 in “grep: avoid using oid_to_hex() with parse_object_or_die()”
  1. grep: avoid using oid_to_hex() with parse_object_or_die()René Scharfe, Jul 28, 2020
  2. Matheus Tavares BernardinoJul 28, 2020
  3. Junio C HamanoJul 28, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.