Re: [PATCH] for-each-repo: do nothing on empty config

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2021, 20:41 UTC
Message-ID: <xmqq1rexssqp.fsf@gitster.c.googlers.com>
In-Reply-To: <3be0a434-d29f-a7b5-fb46-bb1fc1649d27@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 11 quoted lines

>> I wonder if "false" or "exit 1" would fit the bill.  In any case, a
>> comment may help, perhaps?
>> 
>> 	test_expect_success 'do nothing and succeed on empty/missing config' '
>> 		# if this runs even once, "false" ensures a failure
>> 		git for-each-repo --config=bogus.config -- false
>> 	'
>
> I can add a comment, but keep in mind that this example would run the
> subcommand as "git false". This isn't intended as an arbitrary script
> runner, but a "please run the same Git command on a list of repos".

Ah, that is a good point.

The comment needs to explain:

	# the command fails if it attempts to run even once because
	# 'git false' does not exist

and at that point, it does not have to be spelled 'false'. It could be 'no-such-git-subcommand' (and I wonder if that makes the comment unnecessary).

That reminds me. If I have ~/bin/git-false and ~/bin on my $PATH, would this test fail to catch breakage?