Re: [PATCH 1/2] terminal: teach git how to save/restore its terminal settings

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2021, 16:36 UTC
Message-ID: <xmqq1r50ycgf.fsf@gitster.g>
In-Reply-To: <20211004072600.74241-2-carenas@gmail.com>

Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:

Show 10 quoted lines

> diff --git a/compat/terminal.c b/compat/terminal.c
> index 43b73ddc75..1fadbfd6b6 100644
> --- a/compat/terminal.c
> +++ b/compat/terminal.c
> @@ -8,7 +8,7 @@
>  
>  #if defined(HAVE_DEV_TTY) || defined(GIT_WINDOWS_NATIVE)
>  
> -static void restore_term(void);
> +void restore_term(void);

Curious why you need this because (1) we do not have the same for save_term() here, and (2) we include compat/terminal.h where these two are declared next to each other.