Re: [PATCH v4] var: add GIT_DEFAULT_BRANCH variable

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 3, 2021, 20:23 UTC
Message-ID: <xmqq1r3x6l9q.fsf@gitster.g>
In-Reply-To: <20211103201702.117771-1-thomas@t-8ch.de>

Thomas Weißschuh <thomas@t-8ch.de> writes:

> Introduce the logical variable GIT_DEFAULT_BRANCH which represents the
> the default branch name that will be used by "git init".

Sorry for not realizing this earlier, but we are not reporting the "default" with this feature. If you have ~/.gitconfig with your favourite configuration in it, what this reports is the name of the branch created by "git init" without the "--initial-branch=<name>" option.

So GIT_INITIAL_BRANCH_NAME might be a more appropriate name for the variable from that realization. But I do not feel too strongly about it, so let's not keep rerolling but see what others think first.

Thanks.  Will queue this version as-is.  The updated test looks good.

Show 25 quoted lines

> +test_expect_success 'get GIT_DEFAULT_BRANCH without configuration' '
> +	(
> +		sane_unset GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME &&
> +		git init defbranch &&
> +		git -C defbranch symbolic-ref --short HEAD >expect &&
> +		git var GIT_DEFAULT_BRANCH >actual &&
> +		test_cmp expect actual
> +	)
> +'
> +
> +test_expect_success 'get GIT_DEFAULT_BRANCH with configuration' '
> +	test_config init.defaultbranch foo &&
> +	(
> +		sane_unset GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME &&
> +		echo foo >expect &&
> +		git var GIT_DEFAULT_BRANCH >actual &&
> +		test_cmp expect actual
> +	)
> +'
> +
>  # For git var -l, we check only a representative variable;
>  # testing the whole output would make our test too brittle with
>  # respect to unrelated changes in the test suite's environment.
>
> base-commit: 0cddd84c9f3e9c3d793ec93034ef679335f35e49