Re: [PATCH v5] builtin/reflog.c: use parse-options api for expire, delete subcommands

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2022, 21:09 UTC
Message-ID: <xmqq1r1kd11v.fsf@gitster.g>
In-Reply-To: <pull.1175.v5.git.git.1641495981650.gitgitgadget@gmail.com>

"John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 11 quoted lines

> From: John Cai <johncai86@gmail.com>
>
> Switching out manual arg parsing for the parse-options API for the
> expire and delete subcommands.
>
> Move explicit_expiry flag into cmd_reflog_expire_cb struct so callbacks
> can set both the value of the timestamp as well as the explicit_expiry
> flag.
>
> Signed-off-by: "John Cai" <johncai86@gmail.com>
> ---

Thanks.  Will queue.

Show 7 quoted lines

>      @@ builtin/reflog.c: static void set_reflog_expiry_param(struct cmd_reflog_expire_c
>       +	const struct option options[] = {
>       +		OPT_BIT(0, "dry-run", &flags, N_("do not actually prune any entries"),
>       +			EXPIRE_REFLOGS_DRY_RUN),
>      -+		OPT_BIT(0, "rewrite", &flags,
>      ++			OPT_BIT(0, "rewrite", &flags,
>       +			N_("rewrite the old SHA1 with the new SHA1 of the entry that now precedes it"),

I think this change is a fat-finger; will correct while queuing.