Re: t7527 intermittent failure on macOS APFS and possible fix
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 13, 2022, 00:45 UTC
- Message-ID
- <xmqq1qtlas3k.fsf@gitster.g>
- In-Reply-To
- <YvbtVoP01fHF2ka3@danh.dev>
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
Show 5 quoted lines
>> Aren't these protocol drivers? > > The "answer" strbuf is the response from fsmonitor daemon, I think. > The write_in_full to fd 1 is test-tool writes down the answer to > stdout.
Ahh, then please scratch everything I said about this part. Your original implementation makes it more clear that we are "dumping" what we got from the daemon, and then adding LF for our own readability. I somehow mistook the code to be preparing and sending protocol message to the other end (iow, fd #1 was connected to "them").
Sorry about the gotcha, and thanks for straightening me out.