Re: [PATCH] remote: align columns on -v
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 8, 2023, 16:32 UTC
- Message-ID
- <xmqq1qn0ungo.fsf@gitster.g>
- In-Reply-To
- <20230208161222.guqqwlceqiy3jq7e@tb-raspi4>
Torsten Bögershausen <tboegi@web.de> writes:
> Especially, what happens if a remote is named with a non-ASCII > character (unicode code point would be a better term) ? > To determine the width on screen for aligment, strlen() > does the wrong thing here.
Interesting point. I am still skeptical about the patch and suspect that it is better to stick to easy-to-parse output, but if we switch to align for humans, we should definitely count display columns, not byte count with strlen().
Thanks.