Re: [PATCH v2 6/6] cocci & cache.h: remove "USE_THE_INDEX_COMPATIBILITY_MACROS"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2023, 19:42 UTC
Message-ID: <xmqq1qmxi9xq.fsf@gitster.g>
In-Reply-To: <patch-v2-6.6-77c30cfe455-20230210T102114Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 10 quoted lines

> Have the last users of "USE_THE_INDEX_COMPATIBILITY_MACROS" use the
> underlying *_index() variants instead. Now all previous users of
> "USE_THE_INDEX_COMPATIBILITY_MACROS" have been migrated away from the
> wrapper macros, and if applicable to use the "USE_THE_INDEX_VARIABLE"
> added in [1].
>
> Let's leave the "index-compatibility.cocci" in place, even though it
> won't be doing anything on "master". It will benefit any out-of-tree
> code that need to use these compatibility macros. We can eventually
> remove it.

When I saw 2/6 I thought it funny that discard_cache() and read_cache() was left there. So three clean-ups (the other one is the .active_nr member) were done across two patches, which looks a bit funny.

Shouldn't 2/6 and 6/6 combined into one and/or split into three?

The end result is that we need to write our reliance to either the_index or the_repository more explicitly, which may be what some folks want.

Will queue.