Re: [Outreachy][PATCH v5] Port helper/test-ctype.c to unit-tests/t-ctype.c

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 16, 2024, 19:52 UTC
Message-ID: <xmqq1qah12ej.fsf@gitster.g>
In-Reply-To: <41cf1944-2456-4115-a934-aff2306a26e5@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 12 quoted lines

> Am 16.01.24 um 16:38 schrieb Junio C Hamano:
>> Phillip Wood <phillip.wood123@gmail.com> writes:
>>
>>> Thanks for adding back the test for EOF, this version looks good to me.
>>
>> Thanks.  Let's merge it to 'next'.
>
> OK.  I'm still interested in replies to my question in
> https://lore.kernel.org/git/a087f57c-ce72-45c7-8182-f38d0aca9030@web.de/,
> i.e. whether we should have one TEST per class or one per class and
> character -- or in a broader sense: What's the ideal scope of a TEST?
> But I can ask it again in the form of a follow-up patch.

I personally do not have a good answer, but those who are interested in unit-tests more than I do should have their opinions to share ;-)