git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sparse-index: pass string length to index_file_exists()

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 2, 2024, 19:30 UTC
Message-ID
<xmqq1q9usly8.fsf@gitster.g>
In-Reply-To
<2bae709a-18da-6ab8-2b76-032ddc045641@jeffhostetler.com>
Jeff Hostetler <git@jeffhostetler.com> writes:
Show 8 quoted lines
> I don't remember if this bug caused visible problems or not. It felt
> like it caused a few extra rounds of mutually-recursive calls between
> `index_file_exists()` and `expand_to_path()`, but I can't say that
> for certain (and I was focused on a different problem at the time).
>
> I do have some test code in `t/helper/lazy-init-name-hash.c` that
> I suppose we could extend to beat on it, but I'm not sure it is
> worth it in this case.

Yeah, if we had a reproduction already handy that would have been a different story, but I agree that it is not worth it.

Thanks for a fix.  Queued.
Previous: Jeff Hostetler
Message 4 of 4 in “sparse-index: pass string length to index_file_exists()”
  1. sparse-index: pass string length to index_file_exists()Jeff Hostetler via GitGitGadget, Feb 2, 2024
  2. Junio C HamanoFeb 2, 2024
  3. Jeff HostetlerFeb 2, 2024
  4. Junio C HamanoFeb 2, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.