Re: Git branch outputs usage message on stderr
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 15, 2025, 22:11 UTC
- Message-ID
- <xmqq1px3ybf7.fsf@gitster.g>
- In-Reply-To
- <20250115212952.GA96537@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> And it uses code 129, even for "-h". I don't see any explicit rationale > for that in the history; I think it goes back to the beginning of > parse-options. It happens via the PARSE_OPT_HELP flag, but curiously we > also trigger that for ambiguous options (which should exit with error). > That might be a bug-in-waiting if we start handling PARSE_OPT_HELP > differently.
There is another class of callers that are protected by the same "argc == 2 && !strcmp(argv[1], "-h")" condition, and they call usage.c:usage(), instead of calling usage_with_options(). These calls (but not all calls to usage()) need to be updated to use a similar helper, say, show_usage_and_exit_if_asked(). Sigh...