Re: [PATCH v5 15/18] compat/mingw: split out POSIX-related bits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 10, 2025, 15:50 UTC
- Message-ID
- <xmqq1pw5er3q.fsf@gitster.g>
- In-Reply-To
- <c48e8fa2-cca4-4abc-95d2-234fa5c69b8d@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 24 quoted lines
> Am 07.02.25 um 12:52 schrieb Patrick Steinhardt:
>> Split out the POSIX-related bits from "compat/mingw.h". This is in
>> preparation for splitting up "git-compat-utils.h" into a header that
>> provides POSIX-compatibility and a header that provides common wrappers
>> used by the Git project.
>>
>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> ---
>> compat/{mingw.c => mingw/compat-util.c} | 28 ++--
>> compat/mingw/compat-util.h | 220 ++++++++++++++++++++++++++++++++
>> compat/{mingw.h => mingw/posix.h} | 216 +------------------------------
>> compat/msvc.c | 6 -
>> compat/msvc/compat-util.c | 6 +
>> compat/msvc/compat-util.h | 7 +
>> compat/{msvc.h => msvc/posix.h} | 8 +-
>> config.mak.uname | 6 +-
>> contrib/buildsystems/CMakeLists.txt | 2 +-
>> git-compat-util.h | 4 +-
>> meson.build | 8 +-
>> 11 files changed, 266 insertions(+), 245 deletions(-)
>
> I can agree with this rearrangement of compat/mingw.c. But the
> Git-for-Windows repository has much higher stakes with all the
> additional changes. I put Dscho on Cc.Thanks. I agree that it is a very prudent and sensible thing to do to ask for input from Dscho.