Re: [PATCH 1/2] completion: take into account the formatting backticks for options
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 18, 2025, 04:16 UTC
- Message-ID
- <xmqq1puv55y7.fsf@gitster.g>
- In-Reply-To
- <2773494.mvXUDI8C0e@cayenne>
Jean-Noël AVILA <jn.avila@free.fr> writes:
> For the GNUism, the tests on MacOS and Windows by gitgitgadget passed. But I > get your point and will reroll.
Is there a good test in our test suite that validates the output of this script? I had an impression that even if the regexp match by this grep were a bit off, the only end-user visible effect of such a breakage is that some entries from config_name_list[] may be missing when "git help --config-for-completion" is called, but I do not think of any sensible way to notice that some entries are missing or extra entries exist in the output. So unless the regexp is broken so badly that makes the resulting config-list.h syntactically incorrect, it is unlikely that our test suite would catch anything, I suspect.
If I deliberately break the regexp (this is before your patch), it does not seem to break t0012 (which uses --config-for-completion).
generate-configlist.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git c/generate-configlist.sh w/generate-configlist.sh index dffdaada8b..a6eb9739ea 100755 --- c/generate-configlist.sh +++ w/generate-configlist.sh @@ -13,7 +13,7 @@ print_config_list () { cat <<EOF static const char *config_name_list[] = { EOF - grep -h '^[a-zA-Z].*\..*::$' "$SOURCE_DIR"/Documentation/*config.adoc "$SOURCE_DIR"/Documentation/config/*.adoc | + grep -h '^[a-uA-Z].*\..*::$' "$SOURCE_DIR"/Documentation/*config.adoc "$SOURCE_DIR"/Documentation/config/*.adoc | sed '/deprecated/d; s/::$//; s/, */\n/g' | sort | sed 's/^.*$/ "&",/'