Re: What's cooking in git.git (Jul 2025, #06; Tue, 22)

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 23, 2025, 16:46 UTC
Message-ID: <xmqq1pq6q2ia.fsf@gitster.g>
In-Reply-To: <CAPig+cS_h8sC_hEp3zfsUOdP6aFOBucpOsa5TDGwoArHL85Wpg@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 18 quoted lines

> On Tue, Jul 22, 2025 at 8:11 PM Junio C Hamano <gitster@pobox.com> wrote:
>> * hl/test-helper-fd-close (2025-07-22) 2 commits
>>  - t/helper/test-delta: fix possible resource leak and ensure safe cleanup
>>  - t/helper/test-truncate: close file descriptor after truncation
>>
>>  A few file descriptors left unclosed upon program completion in a
>>  few test helper programs are now closed.
>>
>>  Comments?
>>  source: <20250722174102.1876197-1-lhywkd22@gmail.com>
>
> I left comments[*] on patch [2/2]. Although the intention of the
> change seems reasonable (patching holes in the existing "cleanup" of
> `fd`), I have concerns that the commit message is misleading, and
> (more importantly) that the patch itself is flawed. As such, I think a
> reroll is warranted.
>
> [*]: https://lore.kernel.org/git/CAPig+cR-r=CeEaSTeWsX00MLCSRJUUVXMUWS6Ui-HQcR_qMGJA@mail.gmail.com/

Thanks.