git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] doc: git-push: clarify section

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 25, 2025, 15:59 UTC
Message-ID
<xmqq1pnuikuf.fsf@gitster.g>
In-Reply-To
<pull.1973.v2.git.1758651049.gitgitgadget@gmail.com>
"Julia Evans via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 16 quoted lines
> I don't love the nested list in PUSH RULES but the sentence starting with
> "If the source is a tag or commit object..." is really a tough one to read,
> it's not going to be relevant to the vast majority of people, and I think
> keeping it contained inside a bullet point will make it much easier to skip
> over to get to later information which is more likely to be relevant to
> folks.
> ...
> Changes in v2:
>
>  * Say just "The source can be any object." and don't try to educate folks
>    further about tags, from Junio's review
>  * Mention both exceptions to --force working, from Junio's review
>  * Change "local branch or commit being pushed" => "commit being pushed" to
>    make it clear that it's just 1 condition, from Junio's review
>  * Remove an awkward double colon, from Junio's review
>  * Be explicit that creations are always allowed, from Junio's revew

Nothing questionable stood out during my re-read of these two patches.

Further comments from other reviewers are always welcome, but we find needs for immediate improvements, let's mark the topic for 'next'. Thanks.

Previous: Junio C Hamano
Message 15 of 15 in “doc: git-push: clarify section”
  1. 0/2 doc: git-push: clarify sectionJulia Evans via GitGitGadget, Sep 17, 2025
  2. 1/2 doc: git-push: create PUSH RULES sectionJulia Evans via GitGitGadget, Sep 17, 2025
  3. Junio C HamanoSep 17, 2025
  4. Julia EvansSep 18, 2025
  5. 2/2 doc: git-push: rewrite refspec specificationJulia Evans via GitGitGadget, Sep 17, 2025
  6. brian m. carlsonSep 19, 2025
  7. Jeff KingSep 19, 2025
  8. Julia EvansSep 23, 2025
  9. 0/2 doc: git-push: clarify sectionJulia Evans via GitGitGadget, Sep 23, 2025
  10. 1/2 doc: git-push: create PUSH RULES sectionJulia Evans via GitGitGadget, Sep 23, 2025
  11. 2/2 doc: git-push: rewrite refspec specificationJulia Evans via GitGitGadget, Sep 23, 2025
  12. Junio C HamanoSep 23, 2025
  13. Julia EvansSep 23, 2025
  14. Junio C HamanoSep 23, 2025
  15. Junio C HamanoSep 25, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.