Re: [Outreachy PATCH] api-parse-options.adoc: restore a dropped word

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 4, 2026, 23:13 UTC
Message-ID: <xmqq1p90yyul.fsf@gitster.g>
In-Reply-To: <20261104224559.4197-1-herroyalpriestess@gmail.com>

Cynthia Uche <herroyalpriestess@gmail.com> writes:

Show 5 quoted lines

> The description of PARSE_OPT_KEEP_UNKNOWN_OPT ends with "..., the
> parser early.", which is not a sentence. The word "stopping" was lost
> in 0d260f9a09 (parseopt: prevent KEEP_UNKNOWN and STOP_AT_NON_OPTION
> from being used together, 2009-03-09), which rewrote the end of that
> sentence.

Makes sense.  Thanks for finding and fixing.

Show 22 quoted lines

>
> Restore it, and rewrap the following line.
>
> Signed-off-by: Cynthia Uche <herroyalpriestess@gmail.com>
> ---
>  Documentation/technical/api-parse-options.adoc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/technical/api-parse-options.adoc b/Documentation/technical/api-parse-options.adoc
> index 6dfea34220..14f0d2b572 100644
> --- a/Documentation/technical/api-parse-options.adoc
> +++ b/Documentation/technical/api-parse-options.adoc
> @@ -127,8 +127,8 @@ Flags are the bitwise-or of:
>  	`PARSE_OPT_STOP_AT_NON_OPTION` is set, the second argument in
>  	`--unknown value` will be mistakenly interpreted as a
>  	non-option, not as a value belonging to the unknown option,
> -	the parser early.  That's why parse_options() errors out if
> -	both options are set.
> +	stopping the parser early.  That's why parse_options() errors
> +	out if both options are set.
>  	Note that non-option arguments are always kept, even without
>  	this flag.