Re: git diff bug?

From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Apr 6, 2009, 19:32 UTC
Message-ID: <vpqzlet1stg.fsf@bauges.imag.fr>
In-Reply-To: <7vskkl64yu.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 20 quoted lines

> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>
>> Jeff King <peff@peff.net> writes:
>>
>>> But the latter two lines are about preference: "here is how _I_ would
>>> like to generate diffs for el files".
>>
>> ... and they are commands to be executed. If they were in the
>> repository, and propagated with clone, then doing
>>
>> git clone git://some.git/repo
>> cd repo
>> git diff
>>
>> would execute arbitrary commands, which wouldn't be acceptable for
>> security reasons.
>
> Other configuration variables have such security implications, but diff
> hunk header bit doesn't.  You are a bit overly cautious in this particular
> case.

Oops, right, I was thinking of other parameters in the same section of the config file. Thanks for correcting.

-- 
Matthieu