Re: [PATCH] git-remote-mediawiki: better error message when HTTP(S) access fails

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 29, 2013, 12:01 UTC
Message-ID: <vpqzjvej8p4.fsf@anie.imag.fr>
In-Reply-To: <20130528180727.GB21210@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Thu, May 23, 2013 at 10:05:03PM +0200, Matthieu Moy wrote:
>
>> My use-case is an invalid SSL certificate. Pulling from the wiki with a
>> recent version of libwww-perl fails, and git-remote-mediawiki gave no
>> clue about the reason. Give the mediawiki API detailed error message, and
>> since it is not so informative, hint the user about an invalid SSL
>> certificate on https:// urls.
>
> This is definitely an improvement, but it seems like it just the tip of
> the iceberg.

Right.

Show 7 quoted lines

> I wonder if we can do something like:
>
>   our $mw_operation;
>   $mediawiki->{config}->{on_error} = sub {
> [...]
>           die "$err\n";
>   };

Probably, but that would hardcode the fact that mediawiki errors are fatal, while in an ideal world, some errors should be recoverable, and some would require some cleanups before die-ing.

Also, an error during the first mediawiki operation should not necessarily have the same diagnosis hint as the others: if I just did a successfull querry, and the next fails, it can hardly be an SSL certificate error.

I'll send a v2 that covers a bit more (at least, push and pull with an invalid certificate both give the message).

More work is needed to get a real good error management, but I don't have time for that now.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/