"git gc" leaving gc.pid files around

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sep 25, 2013, 18:29 UTC
Message-ID: <vpqzjr0rbz5.fsf@anie.imag.fr>

Hi,

Since 64a99eb47, "git gc" creates a lock file gc.pid while running. I just noticed that the file is never deleted. The locking mechanism works, but leaving these files around creates a minor annoyance.

For example, I run "git gc" in all my repos from time to time (in a cron job). It normally does nothing in repos that have not changed, but now, it updates the gc.pid file.

As a result, all the gc.pid files show up in unison (synchronization tool between machines) for example.

Is there any reason not to do something like this:

--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -316,5 +316,6 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
                warning(_("There are too many unreachable loose objects; "
                        "run 'git prune' to remove them."));
 
+       unlink(git_path("gc.pid"));
        return 0;
 }

?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/